fix: tag removal for 0-line tags (if other tags present, only blank out the tag; otherwise, remove to end of block) #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut the tag; otherwise, remove to end of block); fixes gajus#1040
brettz9
force-pushed
the
check-tag-names-typed
branch
from
58178a1 to
e99f4e8
Compare
|
@JoshuaKGoldberg : I figured it is better to have a fix now, but if you could look at the test cases in this PR, it would help make sure the fixing behavior is as intended. |
|
🎉 This PR is included in version 43.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi sorry for the delay - test cases look great to me! Thank you for fixing this so quickly! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1040
@JoshuaKGoldberg : Could you take a look at the test cases and see if they are as you would expect? I find it a little strange that we are wiping out whole tags including their descriptions unless only one is left, in which case, we leave one description. Should we not wipe it out entirely if that is the goal of the option?