Etherscan could also have a plain source mapping

[wtdcode]

Motivation

Always finding funny things when playing with Etherscan API, try:

curl "https://api.etherscan.io/api?module=contract&action=getsourcecode&address=0x68b26dcf21180d2a8de5a303f8cc5b14c8d99c4c"

This gives a plain source code mapping in the SourceCode field instead of plain source code.

Solution

As shown.

[DaniPopes]

language and settings in SourceCodeMetadata::Metadata are tagged #[serde(default)], so they would be set to None if they are not present. Does that contract not parse already?

[wtdcode]

language and settings in SourceCodeMetadata::Metadata are tagged #[serde(default)], so they would be set to None if they are not present. Does that contract not parse already?

If you try with the link above, you will find that it's missing the key fields, i.e. just plain source code mapping like:

{ "a.sol" : "..." }

EDIT: Oh wait, you are correct, I made a mistake here. Will update the code.

[DaniPopes]

Ah alright, that makes sense.
Shouldn't it be just Sources(HashMap<String, SourceCodeEntry>) then? Updated right as I posted.
Can you also add a test for this case with that contract?

[wtdcode]

Ah alright, that makes sense. Shouldn't it be just Sources(HashMap<String, SourceCodeEntry>,) then? Can you also add a test for this case with that contract?

Fixed already. Regarding the test case, I didn't see any existing test cases actually requesting the network (even no existing test cases for SourceCodeMetadata). Is it proper to make unit tests rely on network service?

[DaniPopes]

You can add one at the bottom of ethers-etherscan/tests/it/contract.rs

[wtdcode]

You can add one at the bottom of ethers-etherscan/tests/it/contract.rs

The problem is not about the place for tests, but how to test it? Request etherscan?

[DaniPopes]

Yes, see can_fetch_contract_source_tree_for_multi_entry_contract in that file, you can copy it and replace the assertions

[wtdcode]

Done

[DaniPopes]

Thanks for spotting this! I've fixed the tests in #2492.