This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Serialize eth_feeHistory
block count as QUANTITY
#668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Retrieving fee history with, say, a
u64
would serialize the theblock_count
as a number twice, instead of first trying as aQUANTITY
which is my understanding of what it is meant to do (i.e. hex-encoded string - e.g.0x42
). This PR aims to fix that.Solution
Instead of serializing the
block_count
that is passed in, it first converts to aU256
(which serializes as aQUANTITY
).PR Checklist