This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: configure rustls & openssl via feature flag #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some downstream foundry users (foundry-rs/foundry#229) are experiencing issues installing on different platforms. I suspect it MIGHT be related to the openssl dependency which was being pulled in by
reqwest
.We can maybe resolve it by feature gating reqwest's SSL provider everywhere, and importing ethers with the
reqwest/rustls
backend.Depends on alloy-rs/svm-rs#11
Also, once seanmonstar/reqwest#1396 is released we should bump reqwest to de-duplicate our certs deps
So this seems to address the issues around
Open problems:
For some reason it triggered WASM to start failing, which is odd given the svm-rs PR above does not change much? Maybe it's the checking-in of the cargo lockfile, in which case it..was already broken?Fixed in 952ac61--all-features
. Is that OK? Might be? Maybe there's a mix between the platform-based configuration that gets us what we need? @mattsse bumped on cargo generate-lockfile doesn't give a working lockfile in some situations rust-lang/cargo#8302 and Platform specific dependencies failing to resolve dependencies with different path rust-lang/cargo#7753 while trying to resolve this, to no success