This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Yul Rust Bindings #993
Closed
Yul Rust Bindings #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uct parameters. Some struct parameters missing.
…riable, it was looking for the Foo contract but the contract was named SimpleStorage. I changed the contract name to Foo and it works now. I added logic to get the bytecode from the compiled yul contract, convert it to a hex string and print it out in the terminal as a str to check the output. Also added some assert!() checks.
…ecode output from compilation.
|
@ControlCplusControlV have you looked at #994? It seems like the same is achieved with a simpler path, so maybe we should consolidate the work? |
|
@gakonst yeah, reading through it now but looks much simpler. I added a comment over there |
|
Closing as we consolidate on 994! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft so a lot is still left undone, and I only have a single test to show for it. Got some help from 0xKitsune on this one though.
It's not too many changes, just a lot of redundant functions. I considered making language a forced parameter of every compiler object but the downstream horror and added arg seemed like it would be too much.
Still need linting but wanted your overall thoughts @gakonst now that new bindings are in a working state