Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running local test creates excessive image rendering. #222

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Mar 26, 2024

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

  • bootstrap.properties comments has a small bug inside. Fixed.
  • build-locally.sh script runs 2 simple tests to up the unit test for extra coverage, instead of 1.
  • found lots of code where err was being checked but we already know it's nill or non-nil.
  • found some code which would trap. eg: err.Error() when we already know err is nil.
  • found some unused parameters. 2 I commented, as i'm unsure why the code is like it is... think there is something wrong in those two areas ?
  • image rendering only happens once after a local run, against the entire home folder.
  • messages suppressed to make logs more readable.
  • removed unused parameters in some places.
  • Local runs : images are rendered only on the runs folders which were created by the runs.
  • Download --force allows images to be overwritten.

This PR fixes CLI: Galsactl logs too much when rendering images during local test runs
#1803

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb techcobweb changed the title docs problem in bootstrap.properties Running local test creates excessive image rendering. Mar 26, 2024
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
pkg/runs/submitter.go Show resolved Hide resolved
pkg/runs/testSelection.go Outdated Show resolved Hide resolved
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 4c7e5f1 into main Apr 2, 2024
4 checks passed
@techcobweb techcobweb deleted the mcobbett-image-render-bug-fix branch April 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants