Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate client secret for the webui #21

Merged
merged 7 commits into from
May 10, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Apr 29, 2024

Why?

Resolves galasa-dev/projectmanagement#1757

Changes

  • Removed the need to register the webui as a client in the values.yaml file, this is now done within the helm chart
    • To avoid breaking existing installations, the auto-generated block for the webui client will only be generated if there is no existing staticClients block in the values.yaml file
  • Added helper methods to simplify the templates to get the URL of the Galasa API server

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@eamansour eamansour merged commit 59ad046 into main May 10, 2024
@eamansour eamansour deleted the em-auto-generated-webui-secret branch May 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate a client secret value for the webui in the helm chart
2 participants