Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable global options in a tool yaml file #26

Merged
merged 7 commits into from
Mar 27, 2017
Merged

Conversation

bgruening
Copy link
Member

@bgruening bgruening commented Mar 25, 2017

This PR will enable global options in a tool yaml files. Means

  install_repository_dependencies: true
  install_resolver_dependencies: true
  install_tool_dependencies: false

can be specified as top arguments next to the Galaxy instance and API key. It will also change the default setting, to install resolver-dependencies and not tool-dependencies anymore.

@bgruening
Copy link
Member Author

@mvdbeek if you have some time, can you look at this please?

@afgane
Copy link
Contributor

afgane commented Mar 27, 2017

@bgruening I think this is really needed and hence glad to see it. I'd just suggest to include a link to the docs explaining those or add a one line comment about each (because for a deployer that's not very invested in the tool dev, the differences between the three options are not really clear).

@bgruening
Copy link
Member Author

@afgane where should this documentation go? In the example yaml?

@afgane
Copy link
Contributor

afgane commented Mar 27, 2017

That would probably be best. Alternatively, above each definition of the global var? (e.g., https://github.com/galaxyproject/ephemeris/pull/26/files#diff-3e2dc1314104230489feb0f417f2d40fR47)

@mvdbeek
Copy link
Member

mvdbeek commented Mar 27, 2017

Maybe we should set repository_dependencies by default to true, to account for suites? Other than that looks good to me.

@bgruening
Copy link
Member Author

Added some docs and changed the default value. Thanks for the review!

@jmchilton
Copy link
Member

Awesome - thanks a bunch @bgruening!

@jmchilton jmchilton merged commit a4dc382 into master Mar 27, 2017
@afgane
Copy link
Contributor

afgane commented Mar 27, 2017

I guess I should have been more explicit because what I meant by docs was to specify differences between tool, repository, and resolver dependencies...

@bgruening
Copy link
Member Author

@afgane this are TS secrets no one knows exactly ;)
I will try my best to add those.

@bgruening bgruening deleted the global_yaml_options branch March 27, 2017 18:33
@afgane
Copy link
Contributor

afgane commented Mar 27, 2017

That's how it feels every time I come cross them...

BTW, I'm really glad to see this switch that happened here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants