Workflow license and creator edit keyboard access #18936
Conversation
itisAliRH
added
kind/enhancement
area/accessibility
|
Can you also remove the save/cancel buttons ? We don't do that anywhere else in the editor |
@mvdbeek The creator form is using it: |
|
oh those buttons are much nicer click targets than the absolutely miniscule 'save' icon that's currently used. Would be very happy to have those larger targets for my poor mouse aim (the reason I use the keyboard to start with) |
|
Yeah, I think removing those save button would be great. |
|
+1 to removing them and saving consistent with other workflow changes. |
|
Thank you all for the comments. So I will remove the buttons and show only the licence selector on the editor. |
itisAliRH
force-pushed
the
workflow-license-creator-keyboard
branch
from
9925cc1 to
024bf21
Compare
| errorMessage.value = errorMessageAsString(error) || "Unable to fetch licenses."; | ||
| } | ||
|
|
||
| licenses.value = data; |
There was a problem hiding this comment.
Could we put this in a store, so it doesn't reload on re-rendering this component?
|
@itisAliRH do you have some time to address the comments ? |
…add error alert, improve button controls and make them accessible via keyboard
…lity Updated the `LicenseSelector` component to enhance user experience by replace a `Multiselect` form `vue-multiselect` dropdown and simplifying the license handling steps and logic.
itisAliRH
force-pushed
the
workflow-license-creator-keyboard
branch
from
024bf21 to
d2ee04e
Compare
Refactors license selection logic in the workflow editor Simplifies selectors and improves interaction handling Enhances test assertions for license value verification
Changes initial licensesLoading state to false Uses watchImmediate for immediate reactivity on inputLicense Ensures licenses are fetched only when not already loading
itisAliRH
force-pushed
the
workflow-license-creator-keyboard
branch
from
baeda70 to
37b4fa4
Compare
Closes #18915. This PR improves the
LicenseSelectorandCreatorEditorui and makes them keyboard accessible. It migratesLicenseSelectorto composition API and typescript, uses GalaxyAPI to fetch license options, and uses theMultiSelectcomponent, simplifying the license handling steps.Workflow.license.and.creator.edit.keyboard.access.mov
How to test the changes?
(Select all options that apply)
License