Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a set subcommand #6

Closed
natefoo opened this issue Feb 13, 2015 · 1 comment
Closed

Implement a set subcommand #6

natefoo opened this issue Feb 13, 2015 · 1 comment
Labels

Comments

@natefoo
Copy link
Member

natefoo commented Feb 13, 2015

The initial use case for this was the need for galaxycfg set instance_name autostart true to override the current hardcoded default of not starting instances when supervisord starts.

However, this led me to consider whether it's better to move the file-driven configuration of [galaxy:server] in galaxy.ini into a command line-driven configuration.

In favor of putting things in galaxy.ini, it's a familiar config interface for admins and those settings persist across removal from gravity, and in a location that is expected by the admin. However, the cli config paradigm seems to be fairly popular these days (see: docker, vagrant, zfs), and has the benefit of allowing for rapid changes and instantaneous syntax checking.

One downside of the cli-driven configuration is that settings would be persisted to a the internal configstate.json which users should not edit by hand. I think people prefer to have the option to config either way - for example, if I was deploying (e.g. with Ansible), I want to be able to write a config file rather than have to call a bunch of shell commands.

@natefoo natefoo added the idea label Feb 13, 2015
natefoo added a commit to natefoo/gravity that referenced this issue Mar 20, 2015
… working,

although no previous state is preserved at this pointi, which will be
necessary to actually update supervisor. Adding/removing configs and
instances is all done via `galaxy create` and `galaxy destroy` now,
e.g.:

    % galaxy create foo/bar config/galaxy.ini

`foo` is the instance name
`bar` is the config's "alias", aka a name that can be worked with

Most of everything else not related to adding/removing configs and
setting options is completely broken because the state file data
structure has completely changed and none of those functions have been
updated yet.
@natefoo
Copy link
Member Author

natefoo commented Oct 28, 2022

This is all outdated and irrelevant, Gravity has its own YAML config section now, the idea of cli configuration was dropped.

@natefoo natefoo closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant