Design goals. #97
Merged
Design goals. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 40.41% 40.41%
=======================================
Files 48 48
Lines 1915 1915
Branches 433 433
=======================================
Hits 774 774
Misses 1025 1025
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mvdbeek
approved these changes
Jul 23, 2024
mvdbeek
reviewed
Jul 23, 2024
mvdbeek
reviewed
Jul 23, 2024
| 1) gxformat2 should be able to be convertible Galaxy's original workflow format without a Galaxy runtime | ||
| 1) gxformat2 should align with workflows standards (and specifically the Common Workflow Langauge) when it is pratical | ||
| 1) We will work on solidifying a version of gxformat2 called 19.09 that is compatible with the workflow models in | ||
| Galaxy versions 19.09-24.1 and which can be fixed for older versions with just a gxformat2 dependency upgrade. |
There was a problem hiding this comment.
Technically we're past this already, since we've added conditionals and other things ...
There was a problem hiding this comment.
I'll revise this then! Good point.
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on the multi-select typing and repeat syntax issues but I wanted to see if we are on the same page around goals first.