Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_alive in favour of isAlive for Python 3.9 compatibility. #225

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Use is_alive in favour of isAlive for Python 3.9 compatibility. #225

merged 1 commit into from
Apr 26, 2020

Conversation

tirkarthi
Copy link
Contributor

Python 2.6 is listed in setup.py but I guess it's safe to ignore it since it was EoL long time ago. Fixes #224

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.12% when pulling dd3b00d on tirkarthi:fix-isalive into 7697513 on galaxyproject:master.

@bgruening
Copy link
Member

bgruening commented Apr 26, 2020 •
edited
Loading

@tirkarthi thanks for your contribution!

@bgruening
Copy link
Member

@tirkarthi thanks a lot. I think it is safe to remove 2.6 also from setup.py

@bgruening bgruening merged commit 06091e4 into galaxyproject:master Apr 26, 2020
@tirkarthi
Copy link
Contributor Author

Thanks for the review and merge :) I didn't run tests with 3.9 . I just grepped for isAlive and studied code to see if change is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isAlive has been deprecated and removed in favor of is_alive in Python 3.9
3 participants
@tirkarthi @coveralls @bgruening