imageWithBlocks fix. Rotate the original image to the right or it sho…

[sunshineo]

…ws upside down.

It used to look like this for me.

As you can see the boxes are at the right place. It is the image that is upside down. Unless I say "threshold" is true, then it is fine.

So it seems that something was wrong with "self.image" orientation. After the change I made:

[ws233]

That's not a universal PR. It only works in your case. What if the image is rotated to a different orientation?
Also any code, which is added to the repo should be test covered.
Would you mind adding tests for you code?

[sunshineo]

It is possible that this problem only occurs for me. I would appreciate if someone can tell me what did I do wrong. I passed Tesseract an image with horizontal text. Tesseract was able to recognize the text. Only problem is when I ask for imageWithBlocks, it gives back an image upside down, when the blocks are at the right location, as shown in the first image. And if I say use threshold, everything is fine. So my feeling is that the orientation of the self.threshold image is correct but self.image is wrong universally.
I will look into how to add test code.

[sunshineo]

Per @ws233 comment on another pull request

The issue is that nevermind of the orientation of the device, the pixels in the image are always located in the same order. Only the imageOriantation tells how to draw the image on the screen.
imageWithBlocks doesn't consider the imageOriantation property of the image.
So you'd better fix the drawing code there.
In the case of the thresholding, the image is preprocessed for you automatically. And if I remember correctly, the preprocessing considers the imageRotation. Therefore you have a correct result after the preprocessing.

So I guess instead of blindly rotate, I need to check imageOriantation property.