Skip to content

Commit

Permalink
[Protocol] Add derives to RequestSettings and new_just_hostname function
Browse files Browse the repository at this point in the history
  • Loading branch information
CosminPerRam committed Oct 7, 2023
1 parent 2106e96 commit 7164ab5
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ Who knows what the future holds...

# 0.X.Y - DD/MM/YYYY
### Changes:
None, yet...
Protocols:
- Minecraft Java: Add derives to `RequestSettings` and add `new_just_hostname` that creates new settings just by specifying
the hostname, `protocol_version` defaults to -1.

### Breaking...
None, yaay!
Expand Down
16 changes: 14 additions & 2 deletions src/protocols/minecraft/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ pub struct JavaResponse {
}

/// Java-only additional request settings.
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
pub struct RequestSettings {
/// Some Minecraft servers do not respond as expected if this
/// isn't a specific value, `mc.hypixel.net` is an example.
Expand All @@ -99,8 +101,7 @@ pub struct RequestSettings {
}

impl Default for RequestSettings {
/// `hostname`: "gamedig"
///
/// `hostname`: "gamedig"
/// `protocol_version`: -1
fn default() -> Self {
Self {
Expand All @@ -110,6 +111,17 @@ impl Default for RequestSettings {
}
}

impl RequestSettings {
/// Make a new *RequestSettings* with just the hostname, the protocol
/// version defaults to -1
pub fn new_just_hostname(hostname: String) -> Self {
Self {
hostname,
protocol_version: -1,
}
}
}

impl From<ExtraRequestSettings> for RequestSettings {
fn from(value: ExtraRequestSettings) -> Self {
let default = Self::default();
Expand Down

0 comments on commit 7164ab5

Please sign in to comment.