Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Only run build checks when a rust related file has changed #102

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[CI] Only run build checks when a rust related file has changed #102

merged 1 commit into from
Sep 21, 2023

Conversation

Douile
Copy link
Collaborator

@Douile Douile commented Sep 21, 2023

This should save us a few actions minutes with all the CI PRs lately :).

@Douile Douile force-pushed the fix/ci-only-when-rust-changed branch from 7aac4dd to e5e33c5 Compare September 21, 2023 19:38
@github-actions github-actions bot added the ci Continous integration label Sep 21, 2023
@CosminPerRam
Copy link
Member

Hmm, would we need to also add Cargo.lock to these files? It's a generated file, yeah, but maybe we could touch it by accident?

@Douile
Copy link
Collaborator Author

Douile commented Sep 21, 2023

Hmm, would we need to also add Cargo.lock to these files

It's in the .gitignore so shouldn't ever be added to the repo, but could add anyway.

@CosminPerRam
Copy link
Member

Oh, completely forgot its in .gitignore, I guess thats fine.
... or maybe not?
Anyways, out of the scope of this pr.

@CosminPerRam CosminPerRam merged commit 1a60a04 into gamedig:main Sep 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Douile @CosminPerRam