Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md. #108
Add CONTRIBUTING.md. #108
Changes from 12 commits
eceb528
77df3bd
ca4f9b8
ba66c9c
cad4a9a
1be8771
f192a83
f58e1f2
e4643b3
0a5c379
2e0b524
e356cdd
0922e18
51e87f0
06786a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mentions the case for the auto query but doesn't tell us what to do for individual protocols. Should we stop adding ids for individual protocols e.g.
minecraftjava
?Or should that already be included as a word anyway. I have been leaving out because the protocol is wrapped in
()
, which is similar to how the year is extra info, but games could included()
in their titles anyway.Perhaps adding the protocol should be specified in name rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good for the ID I think, we should also mention whether the protocol is to be added to the pretty name though.