Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minecraft id naming inconsistencies #152

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

CosminPerRam
Copy link
Member

@CosminPerRam CosminPerRam commented Nov 10, 2023

The PR for testing game ids (#111) is still stuck on Minecraft ids being weirdly named, this PR simplifies them and also renames Legacy Beta V1.8-1.3 and 1.4-1.5, they are now named the lowest version they support.

@github-actions github-actions bot added protocol This is something regarding a protocol game This is something regarding a game labels Nov 10, 2023
@CosminPerRam CosminPerRam marked this pull request as ready for review November 13, 2023 20:32
@CosminPerRam CosminPerRam requested a review from Douile November 13, 2023 20:33
Copy link
Collaborator

@Douile Douile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CosminPerRam CosminPerRam merged commit bd73b65 into main Nov 16, 2023
13 checks passed
@cainthebest cainthebest deleted the fix/minecraft_naming_inconsistencies branch January 13, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
game This is something regarding a game protocol This is something regarding a protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants