Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply clippy suggestions #208

Merged
merged 2 commits into from
Jun 29, 2024
Merged

chore: apply clippy suggestions #208

merged 2 commits into from
Jun 29, 2024

Conversation

CosminPerRam
Copy link
Member

@CosminPerRam CosminPerRam commented Jun 22, 2024

Applied assigning_clones which could help performance.
Andredundant_static_lifetimes which just cleans up obvious a lifetime.

I also have sorted out some unused imports warnings, see below comment.

@github-actions github-actions bot added protocol This is something regarding a protocol game This is something regarding a game labels Jun 22, 2024
@CosminPerRam
Copy link
Member Author

warning: unused import: `protocol::*`                                                                                                                                                                                      
 --> crates\lib\src\games\minecraft\mod.rs:7:9
  |
7 | pub use protocol::*;
  |         ^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `query::*`                                                                                                                                                                                         
  --> crates\lib\src\lib.rs:59:9
   |
59 | pub use query::*;
   |         ^^^^^^^^

We need these for easier user use, so I just #[allow(unused_import)].


warning: unused import: `crate::protocols::epic::Credentials`
  --> crates\lib\src\games\definitions.rs:12:5
   |
12 | use crate::protocols::epic::Credentials;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We didn't used this anywhere in that scope, so I removed it.

@CosminPerRam CosminPerRam changed the title perf: apply clippy suggestions chore: apply clippy suggestions Jun 22, 2024
Copy link
Member

@cainthebest cainthebest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These clippy and import fixs LGTM

@CosminPerRam CosminPerRam merged commit 79aeec8 into main Jun 29, 2024
14 checks passed
@cainthebest cainthebest deleted the perf/apply_clippy branch July 15, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
game This is something regarding a game protocol This is something regarding a protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants