Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: read string may panic index out of range #221

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Fix: read string may panic index out of range #221

merged 4 commits into from
Sep 7, 2024

Conversation

cainthebest
Copy link
Member

Adds a out of bounds check and error handling on read string within buffer to handle a panic that may occur.

@cainthebest cainthebest linked an issue Sep 6, 2024 that may be closed by this pull request
Index out of range panic #220
Closed
CosminPerRam
CosminPerRam approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@CosminPerRam CosminPerRam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now to avoid the panic (also as a safety net just in case), but if node does the query it means there still are some discrepancies between them.

@cainthebest cainthebest merged commit ada3c54 into main Sep 7, 2024
14 checks passed
@cainthebest cainthebest deleted the fix/read-string-may-panic-index-out-of-range branch September 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CosminPerRam CosminPerRam CosminPerRam approved these changes

@paul-hansen paul-hansen paul-hansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index out of range panic
3 participants
@cainthebest @paul-hansen @CosminPerRam