Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update quick-xml requirement from 0.36.0 to 0.37.0 in /crates/cli #227

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Updates the requirements on quick-xml to permit the latest version.

Release notes

Sourced from quick-xml's releases.

v0.37.0 - serde & errors imporvements

What's Changed

⚠️ Significant Changes

Those changes could require not trivial adoption of your code:

  • The recognized boolean values in serde Deserializer are reduced. Use #[serde(deserialize_with)] which will accept and parse strings if you need the old behavior.
  • Serializer no longer serialize consequent primitive values (those which would produce only text, without surrounding tags), because it is impossible to deserialize them back to the same value.
  • The crate's errors was changed, some variants was splitted to their own error types, some removed.

New Features

  • #826: Implement From<String> and From<Cow<str>> for quick_xml::de::Text.
  • #826: Make SimpleTypeDeserializer and SimpleTypeSerializer public.
  • #826: Implement IntoDeserializer for &mut Deserializer.

Bug Fixes

  • #655: Do not write indent before and after $text fields and those $value fields that are serialized as a text (for example, usize or String).
  • #826: Handle only those boolean representations that are allowed by [Xml Schema] which is only "true", "1", "false", and "0". Previously the following values also was accepted:
    bool XML content
    true "True", "TRUE", "t", "Yes", "YES", "yes", "y"
    false "False", "FALSE", "f", "No", "NO", "no", "n"

Misc Changes

  • #227: Split SeError from DeError in the serialize feature. Serialize functions and methods now return SeError.
  • #810: Return std::io::Error from Writer methods.
  • #811: Split NamespaceError and EncodingError from Error.
  • #811: Renamed Error::EscapeError to Error::Escape to match other variants.
  • #811: Narrow down error return type from Error where only one variant is ever returned: attribute related methods on BytesStart and BytesDecl returns AttrError.
  • #820: Classify output of the Serializer by returning an enumeration with kind of written data.
  • #823: Do not allow serialization of consequent primitives, for example Vec<usize> or Vec<String> in $value fields. They cannot be deserialized back with the same result.
  • #827: Make escape and it variants take a impl Into<Cow<str>> argument and implement From<(&'a str, Cow<'a, str>)> on Attribute.
  • #826: Removed DeError::InvalidInt, DeError::InvalidFloat and DeError::InvalidBoolean. Now the responsibility for returning the error lies with the visitor of the type. See rationale in serde-rs/serde#2811

#227: tafia/quick-xml#227 #655: tafia/quick-xml#655 #810: tafia/quick-xml#810 #811: tafia/quick-xml#811 #820: tafia/quick-xml#820 #823: tafia/quick-xml#823 #826: tafia/quick-xml#826 #827: tafia/quick-xml#827 [Xml Schema]: https://www.w3.org/TR/xmlschema11-2/#boolean

New Contributors

... (truncated)

Changelog

Sourced from quick-xml's changelog.

0.37.0 -- 2024-10-27

New Features

  • #826: Implement From<String> and From<Cow<str>> for quick_xml::de::Text.
  • #826: Make SimpleTypeDeserializer and SimpleTypeSerializer public.
  • #826: Implement IntoDeserializer for &mut Deserializer.

Bug Fixes

  • #655: Do not write indent before and after $text fields and those $value fields that are serialized as a text (for example, usize or String).
  • #826: Handle only those boolean representations that are allowed by [Xml Schema] which is only "true", "1", "false", and "0". Previously the following values also was accepted:
    bool XML content
    true "True", "TRUE", "t", "Yes", "YES", "yes", "y"
    false "False", "FALSE", "f", "No", "NO", "no", "n"

Misc Changes

  • #227: Split SeError from DeError in the serialize feature. Serialize functions and methods now return SeError.
  • #810: Return std::io::Error from Writer methods.
  • #811: Split NamespaceError and EncodingError from Error.
  • #811: Renamed Error::EscapeError to Error::Escape to match other variants.
  • #811: Narrow down error return type from Error where only one variant is ever returned: attribute related methods on BytesStart and BytesDecl returns AttrError
  • #820: Classify output of the Serializer by returning an enumeration with kind of written data
  • #823: Do not allow serialization of consequent primitives, for example Vec<usize> or Vec<String> in $value fields. They cannot be deserialized back with the same result
  • #827: Make escape and it variants take a impl Into<Cow<str>> argument and implement From<(&'a str, Cow<'a, str>)> on Attribute
  • #826: Removed DeError::InvalidInt, DeError::InvalidFloat and DeError::InvalidBoolean. Now the responsibility for returning the error lies with the visitor of the type. See rationale in serde-rs/serde#2811

#227: tafia/quick-xml#227 #655: tafia/quick-xml#655 #810: tafia/quick-xml#810 #811: tafia/quick-xml#811 #820: tafia/quick-xml#820 #823: tafia/quick-xml#823 #826: tafia/quick-xml#826 #827: tafia/quick-xml#827 [Xml Schema]: https://www.w3.org/TR/xmlschema11-2/#boolean

0.36.2 -- 2024-09-20

... (truncated)

Commits
  • 3ac75a6 Release 0.37.0
  • 7799744 Sort dependencies and table of tests which requires features
  • 8311eef Rename test xmlrs_reader_tests -> html and run it only when escape-html featu...
  • a6c5fc5 Merge pull request #826 from Mingun/more-deserializers
  • 83d2957 Implement IntoDeserializer for public deserializers
  • 9218684 Make SimpleTypeDeserializer and SimpleTypeSerializer public
  • 1920e03 Implement From<String> and From<Cow> for quick_xml::de::Text
  • 45a66e5 Do not report errors if deserializer cannot convert string to the boolean or ...
  • b285fc9 Move deserialization helper from Content to CowRef
  • 62f10dd Forward deserialization of primitives in SimpleTypeDeserializer to AtomicDese...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 28, 2024
@github-actions github-actions bot added the cli label Oct 28, 2024
@CosminPerRam
Copy link
Member

I've re-ran the security audit 2 times and its failing with the same error, what?

@cainthebest
Copy link
Member

looks like its trying to find a lockfile but we dont commit that to the repo

image

@cainthebest
Copy link
Member

I think the new major semver (v2) stopped using generate lockfile like v1.4.1 did

image

@CosminPerRam
Copy link
Member

all should be good now by #229

@dependabot rebase

Updates the requirements on [quick-xml](https://github.com/tafia/quick-xml) to permit the latest version.
- [Release notes](https://github.com/tafia/quick-xml/releases)
- [Changelog](https://github.com/tafia/quick-xml/blob/master/Changelog.md)
- [Commits](tafia/quick-xml@v0.36.0...v0.37.0)

---
updated-dependencies:
- dependency-name: quick-xml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/crates/cli/quick-xml-0.37.0 branch from 18edb6f to 24134d6 Compare October 29, 2024 20:44
@CosminPerRam
Copy link
Member

@cainthebest I think I'm having a brain fart, why the audit didn't ran now and before it did?

@cainthebest
Copy link
Member

Im unsure on that 1 but maybe as there wasn't a change in the cargo file?

this is the event it runs on

on:
push:
paths:
- '**/Cargo.toml'
- '**/Cargo.lock'

you could also add the workflow dispatch to be able to manually call the job like here
https://github.com/gamedig/gamedig.github.io/blob/main/.github/workflows/deploy.yml

in actions tab it will appear like this
image

@cainthebest
Copy link
Member

Im just going to merge this for now

@cainthebest cainthebest merged commit 6aa9006 into main Nov 7, 2024
9 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/crates/cli/quick-xml-0.37.0 branch November 7, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants