Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken undefined link in data_fermi_lat.ipynb #89

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Fix broken undefined link in data_fermi_lat.ipynb #89

merged 1 commit into from
Oct 21, 2017

Conversation

Bultako
Copy link
Member

@Bultako Bultako commented Oct 20, 2017

Fix undesired warning in the notebooks doc generation made by nbsphinx
Links in notebooks should not be broken to avoid warnings.

@Bultako Bultako mentioned this pull request Oct 20, 2017
Merged
7 tasks
@cdeil
Copy link
Contributor

cdeil commented Oct 21, 2017

@Bultako - Thanks!

In the IPYNB diff I see a "toc" entry is added. What is that? We don't have it for any other notebook? Is this something I can ignore?

At least on nbviewer it doesn't show up:
https://nbviewer.jupyter.org/github/Bultako/gammapy-extra/blob/10f32a5bd57eb46a2539683da81a0d835280ba6e/notebooks/data_fermi_lat.ipynb

@cdeil cdeil merged commit 3044653 into gammapy:master Oct 21, 2017
@Bultako
Copy link
Member Author

Bultako commented Oct 23, 2017

@cdeil
doc entry in json metadata is something related with my own Jupyter env local config, the "table of contents" extension. of course you can ignore that, I don't know how to get rid of these metadata..

@Bultako Bultako deleted the docbuilding-notebooks branch October 23, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bultako @cdeil