Fix warning

gammasoft71 · Sep 20, 2024 · 5db57d2 · 5db57d2
1 parent 9a3025b
commit 5db57d2
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/src/xtd.core/include/xtd/comparison_operators.h b/src/xtd.core/include/xtd/comparison_operators.h
@@ -34,25 +34,37 @@ namespace xtd {
     /// @param lhs The left hand side value to compare.
     /// @param rhs The right hand side value to compare.
     /// @return true if lhs less than rhs; otherwise false.
-    friend bool operator <(const type_t& lhs, const type_t& rhs) noexcept {return dynamic_cast<const type_t*>(&rhs) && lhs.compare_to(static_cast<const type_t&>(rhs)) < 0;}
+    friend bool operator <(const type_t& lhs, const type_t& rhs) noexcept {
+      auto rhs_ptr = &rhs;
+      return dynamic_cast<const type_t*>(rhs_ptr) && lhs.compare_to(static_cast<const type_t&>(rhs)) < 0;
+      }
 
     /// @brief Less than or equal to comparison operator with specidied lhs ans rhs values.
     /// @param lhs The left hand side value to compare.
     /// @param rhs The right hand side value to compare.
     /// @return true if lhs less than or equal to rhs; otherwise false.
-    friend bool operator <=(const type_t& lhs, const type_t& rhs) noexcept {return dynamic_cast<const type_t*>(&rhs) && lhs.compare_to(static_cast<const type_t&>(rhs)) <= 0;}
+    friend bool operator <=(const type_t& lhs, const type_t& rhs) noexcept {
+      auto rhs_ptr = &rhs;
+      return dynamic_cast<const type_t*>(rhs_ptr) && lhs.compare_to(static_cast<const type_t&>(rhs)) <= 0;
+      }
 
     /// @brief Greater than or equal to comparison operator with specidied lhs ans rhs values.
     /// @param lhs The left hand side value to compare.
     /// @param rhs The right hand side value to compare.
     /// @return true if lhs greater than rhs; otherwise false.
-    friend bool operator >(const type_t& lhs, const type_t& rhs) noexcept {return dynamic_cast<const type_t*>(&rhs) && lhs.compare_to(static_cast<const type_t&>(rhs)) > 0;}
+    friend bool operator >(const type_t& lhs, const type_t& rhs) noexcept {
+      auto rhs_ptr = &rhs;
+      return dynamic_cast<const type_t*>(rhs_ptr) && lhs.compare_to(static_cast<const type_t&>(rhs)) > 0;
+      }
 
     /// @brief Less than comparison operator with specidied lhs ans rhs values.
     /// @param lhs The left hand side value to compare.
     /// @param rhs The right hand side value to compare.
     /// @return true if lhs greater than or equal to rhs; otherwise false.
-    friend bool operator >=(const type_t& lhs, const type_t& rhs) noexcept {return dynamic_cast<const type_t*>(&rhs) && lhs.compare_to(static_cast<const type_t&>(rhs)) >= 0;}
+    friend bool operator >=(const type_t& lhs, const type_t& rhs) noexcept {
+      auto rhs_ptr = &rhs;
+      return dynamic_cast<const type_t*>(rhs_ptr) && lhs.compare_to(static_cast<const type_t&>(rhs)) >= 0;
+      }
 
 #if defined(__xtd__cpp_lib_three_way_comparison)
     /// @brief Three-way comparison operator with specidied lhs ans rhs values.