-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the capability to control the timezone used to display rrd metric graphs #245
Conversation
…ic graphs and reports. This is accomplished by specifying a tz query parameter to the ganaglia-web url. The timezone parameter takes the standard Linux form, e.g. tz=UTC, tz=America/New_York
Peter, is there a UI to set it or is the only way to set the timezone to query parameter ? Perhaps adding it as a drop down would be helpful. Does it also affect the JS graphs ? |
Hi Vladimir, The current implementation does not affect inspect graphs and event input which already assume a browser timezone. I have also not made any modifications to the xport functionality that I believe is used to generate the graph-engine/flot graphs. You could argue that with gweb now having a timezone all functionality involving time including inspect graphs, event input should honor it. We also need to think about the default timezone value (we can continue with server, but provide a conf option to default to browser), and whether the selected timezone should be persisted across sessions. Peter From: Vladimir Vuksan [mailto:notifications@github.com] Peter, is there a UI to set it or is the only way to set the timezone to query parameter ? Perhaps adding it as a drop down would be helpful. Does it also affect the JS graphs ? — |
Vladimir, Peter From: Vladimir Vuksan [mailto:notifications@github.com] Peter, is there a UI to set it or is the only way to set the timezone to query parameter ? Perhaps adding it as a drop down would be helpful. Does it also affect the JS graphs ? — |
I'd do browser and server. On 23. kolovoza 2014. 13:42:54 EDT, pcpiela notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
Use jstz to determine browser timezone. In the future my hope is that we can do this with the moment library.
Some cleanup work in the area of date/time manipulation.
Vladimir, Peter |
…ression to allow for hyphens.
…ly display the "now" button if the gweb timezone is set to "browser"
Added the capability to control the timezone used to display rrd metric graphs
Added the capability to control the timezone used to display rrd metric graphs. This is accomplished by specifying a tz query parameter to the ganglia-web url. The timezone parameter takes the standard Linux form, e.g. tz=UTC, tz=America/New_York. The specified timezone is stored as a session variable.