Micro-optimize XML calls #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
First Commit: Don't global variables that aren't actually used at all.
Second Commit: If debug is not enabled, don't even put it in the call stack. This removes the debug() check on production path, but lets you still enable it with ?debug=1 (as you would before)
Third Commit: Only global a variable if we truly need it. The less variables we look up, the faster it is.
Overall, these changes saved about 10% on page loading time against 26mb of XML. (If I remember correctly anyways. I wrote this a while back.)
I apologize for the first commit being a merge - my gitfu is weak.