Fixed Ansible Lint warnings (#120)

In preparation for Molecule upgrade.

.yamllint

@@ -30,4 +30,5 @@ rules:
   new-lines:
     type: unix
   trailing-spaces: disable
-  truthy: disable
+  truthy:
+    allowed-values: ['true', 'false', 'on']

handlers/main.yml

@@ -1,8 +1,8 @@
 ---
-- name: 'xdesktop: apply glib schemas changes'
-  become: yes
-  command: '/usr/bin/glib-compile-schemas {{ xdesktop_glib_schemas_directory }}'
+- name: 'X-Desktop: apply glib schemas changes'
+  become: true
+  ansible.builtin.command: '/usr/bin/glib-compile-schemas {{ xdesktop_glib_schemas_directory }}'
 
-- name: update font-cache
-  become: yes
-  command: fc-cache -fv
+- name: Update font-cache
+  become: true
+  ansible.builtin.command: fc-cache -fv

molecule/default/converge.yml

@@ -3,10 +3,10 @@
   hosts: all
 
   pre_tasks:
-    - name: update apt cache
-      apt:
-        update_cache: yes
-      changed_when: no
+    - name: Update apt cache
+      ansible.builtin.apt:
+        update_cache: true
+      changed_when: false
 
   roles:
     - role: ansible-role-xdesktop

tasks/accessories.yml

@@ -1,7 +1,7 @@
 ---
-- name: install accessory apps and fonts
-  become: yes
-  apt:
+- name: Install accessory apps and fonts
+  become: true
+  ansible.builtin.apt:
     name:
       # Terminal emulator
       - terminator

tasks/gnome-desktop-configure.yml

@@ -1,44 +1,44 @@
 ---
-- name: write xorg screensaver config
-  become: yes
-  template:
+- name: Write xorg screensaver config
+  become: true
+  ansible.builtin.template:
     src: screensaver.conf.j2
     dest: '/usr/share/X11/xorg.conf.d/60-ansible-screensaver.conf'
     owner: root
     group: root
     mode: 'u=rw,go=r'
 
-- name: write gnome screensaver config
-  become: yes
-  template:
+- name: Write gnome screensaver config
+  become: true
+  ansible.builtin.template:
     src: screensaver.gschema.override.j2
     dest: '{{ xdesktop_glib_schemas_directory }}/20_ansible_screensaver.gschema.override'
     owner: root
     group: root
     mode: 'u=rw,go=r'
   register: screensaver_config
 
-- name: write gnome lock screen config
-  become: yes
-  template:
+- name: Write gnome lock screen config
+  become: true
+  ansible.builtin.template:
     src: lockscreen.gschema.override.j2
     dest: '{{ xdesktop_glib_schemas_directory }}/20_ansible_lockscreen.gschema.override'
     owner: root
     group: root
     mode: 'u=rw,go=r'
   register: lockscreen_config
 
-- name: assert dock position valid
+- name: Assert dock position valid
   assert:
     that:
       - "xdesktop_dock_position in ('LEFT', 'RIGHT', 'BOTTOM')"
 
-- name: write gnome dock config
-  become: yes
-  template:
+- name: Write gnome dock config
+  become: true
+  ansible.builtin.template:
     src: dock.gschema.override.j2
     dest: '{{ xdesktop_glib_schemas_directory }}/20_ansible_dock.gschema.override'
     owner: root
     group: root
     mode: 'u=rw,go=r'
-  notify: 'xdesktop: apply glib schemas changes'
+  notify: 'X-Desktop: apply glib schemas changes'

tasks/gnome-desktop-install.yml

@@ -1,7 +1,7 @@
 ---
-- name: install ubuntu-desktop
-  become: yes
-  apt:
+- name: Install ubuntu-desktop
+  become: true
+  ansible.builtin.apt:
     name:
       - ubuntu-desktop
       # Archive manager
@@ -15,4 +15,4 @@
       - yaru-theme-icon
       - yaru-theme-unity
     state: present
-    install_recommends: no
+    install_recommends: false

tasks/nerd-font.yml

@@ -1,43 +1,43 @@
 ---
-- name: create download directory
-  file:
+- name: Create download directory
+  ansible.builtin.file:
     state: directory
     mode: 'u=rwx,go=rx'
     dest: '{{ xdesktop_download_dir }}'
 
-- name: download Nerd Font
-  get_url:
+- name: Download Nerd Font
+  ansible.builtin.get_url:
     url: '{{ xdesktop_nerd_font_redis_url }}'
     checksum: 'sha256:{{ xdesktop_nerd_font_redis_sha256sum }}'
     dest: '{{ xdesktop_download_dir }}/{{ xdesktop_nerd_font_local_filename }}'
-    force: no
+    force: false
     mode: 'u=rw,go=r'
 
-- name: create font directory
-  become: yes
-  file:
+- name: Create font directory
+  become: true
+  ansible.builtin.file:
     state: directory
     mode: 'u=rwx,g=rwxs,o=rx'
     dest: '{{ xdesktop_font_install_directory }}'
 
-- name: install Nerd Font
-  become: yes
-  unarchive:
+- name: Install Nerd Font
+  become: true
+  ansible.builtin.unarchive:
     src: '{{ xdesktop_download_dir }}/{{ xdesktop_nerd_font_local_filename }}'
-    remote_src: yes
+    remote_src: true
     dest: '{{ xdesktop_font_install_directory }}'
     include: '{{ xdesktop_nerd_font_install_files }}'
     mode: 'ug=rw,o=r'
     owner: root
     group: staff
-  notify: update font-cache
+  notify: Update font-cache
 
-- name: write monospace font config
-  become: yes
-  template:
+- name: Write monospace font config
+  become: true
+  ansible.builtin.template:
     src: monospace_font.gschema.override.j2
     dest: '{{ xdesktop_glib_schemas_directory }}/20_ansible_monospace_font.gschema.override'
     owner: root
     group: root
     mode: 'u=rw,go=r'
-  notify: 'xdesktop: apply glib schemas changes'
+  notify: 'X-Desktop: apply glib schemas changes'