Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize package status into a single file #330

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

fingolfin
Copy link
Member

Instead of letting each package keep track of its own status as a
deposited or refereed package, we now collect this information
centrally. This makes more sense, and also avoids some awkwardness

For example, in order to be accepted for distribution, currently GAP
package authors must provide a proper release of their package, which
then is reviewed. But that release should not yet have status accepted
resp. deposited... so strictly speaking, right after the package is
officially accepted, a second release with the updated status should be
made right away.

With a centralized list of deposited and accepted packages, there is no
need anymore for packages metadata to contain this information.

Instead of letting each package keep track of its own status as a
deposited or refereed package, we now collect this information
centrally. This makes more sense, and also avoids some awkwardness

For example, in order to be accepted for distribution, currently GAP
package authors must provide a proper release of their package, which
then is reviewed. But that release should not yet have status `accepted`
resp. `deposited`... so strictly speaking, right after the package is
officially accepted, a second release with the updated status should be
made right away.

With a centralized list of deposited and accepted packages, there is no
need anymore for packages metadata to contain this information.
@fingolfin
Copy link
Member Author

We could also add more data in the future... e.g. the version of the package that was "accepted" would probably be interesting for users.

Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need to remove the relevant fields from the package-infos/4-X-Y.json data files, but I don't object, either.

Otherwise, this is a nice change.

@fingolfin fingolfin merged commit c247f26 into gap-system:master Aug 25, 2023
1 check passed
@fingolfin fingolfin deleted the mh/package-status branch August 25, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants