Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Include syntax checking on deployments #41

Closed
garciparedes opened this issue Aug 31, 2019 · 0 comments
Closed

Include syntax checking on deployments #41

garciparedes opened this issue Aug 31, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request miscellaneous This issue is related with anything different from source code.
Milestone

Comments

@garciparedes
Copy link
Owner

Is your feature request related to a problem? Please describe.
The code quality should be one of the most important things around the development of this project. For that reason, it's necessary to define properly settings over the workflow that help us to validate this objective.

Describe the solution you'd like
Include flake8 as development dependency to validate the proper syntax of the code. This checking should be applied at each Travis build and fail the task if there are any error.

Describe alternatives you've considered
We can implement this checking using another validation tools like Pylint, mypy or pyflakes, but I think that flake8 is a good starting point that can be extended with one (or more) of the described alternative tools.

Additional context
This issue should be implemented through a different branch with its corresponding pull request because it is probably necessary to perform some code improvements.

@garciparedes garciparedes added enhancement New feature or request miscellaneous This issue is related with anything different from source code. labels Aug 31, 2019
@garciparedes garciparedes self-assigned this Aug 31, 2019
garciparedes added a commit that referenced this issue Aug 31, 2019
* Created configuration file.
* Included "flake8" validation on Travis deployments.
#41
garciparedes added a commit that referenced this issue Aug 31, 2019
This was referenced Aug 31, 2019
garciparedes added a commit that referenced this issue Sep 1, 2019
garciparedes added a commit that referenced this issue Sep 1, 2019
garciparedes added a commit that referenced this issue Sep 1, 2019
* Included "deepcopy" method for "GeometricPosition"
garciparedes added a commit that referenced this issue Sep 1, 2019
* Included test for "Vehicle.as_dict()".
garciparedes added a commit that referenced this issue Sep 1, 2019
* Fixed bug related with exception handling.
garciparedes added a commit that referenced this issue Sep 1, 2019
* Improved tests for all "Algorithm" heirs.
* Fixed bug related with the criterion settings.
@garciparedes garciparedes added this to the r0.1.0 milestone Jan 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request miscellaneous This issue is related with anything different from source code.
Projects
None yet
Development

No branches or pull requests

1 participant