Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): error when running garden in a workflow script step #2417

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented May 28, 2021

This works around vercel/pkg#897 by patching
the pkg prelude/bootstrap.js script.

Fixes #2032

@edvald
Copy link
Collaborator Author

edvald commented May 28, 2021

@eysi09 please give it a spin on your side as well. I tested this to work for me, but ya never know.

@eysi09
Copy link
Collaborator

eysi09 commented May 31, 2021

@thsig, can you review this one? It's hi-pri and I'm stuck in calls today :)

@eysi09 eysi09 assigned thsig and unassigned eysi09 May 31, 2021
@thsig thsig force-pushed the fix-garden-in-workflow branch 2 times, most recently from ff3f2f5 to cd8a8d7 Compare June 1, 2021 11:43
@thsig
Copy link
Collaborator

thsig commented Jun 1, 2021

@edvald: The build-dist step is failing here.

@edvald edvald force-pushed the fix-garden-in-workflow branch 3 times, most recently from acbfb63 to ea8d0f2 Compare June 2, 2021 12:35
@edvald
Copy link
Collaborator Author

edvald commented Jun 2, 2021

This should be good to go now @thsig. We should manually test the CI-built binaries though, particularly on Windows.

This works around vercel/pkg#897 by patching
the `pkg` `prelude/bootstrap.js` script.

Fixes #2032
@thsig thsig merged commit dd81223 into master Jun 7, 2021
@thsig thsig deleted the fix-garden-in-workflow branch June 7, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unable to run garden tools command inside exec modules
3 participants