chore(helm): relax path validation requirements for valueFiles #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walther
changed the title
edvald
approved these changes
Jan 7, 2023
|
Just as I hit the approve button, I'm noticing that the commit messages need to be fixed. I'm doing it in the squash now so no big deal, but note that |
vvagaytsev
pushed a commit
that referenced
this pull request
Jan 24, 2023
…3445) * chore: relax path validation requirements for valueFiles * chore: add rudimentary test for relative path in valueFiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Relaxes the path validation requirements for
valueFilesfield in helm modules.Which issue(s) this PR fixes:
Fixes #3367
Introduces #3487
Special notes for your reviewer:
Based on internal conversations, we're essentially trading issues here: allow users to specify the valueFiles in a bit more flexible manner to unblock them, while introducing the slight risk of possible version/cache invalidation issues.