fix(pulumi): include build deps in plugin commands #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
approved these changes
Jul 8, 2024
vvagaytsev
requested changes
Jul 8, 2024
In 0.12, we included build dependencies for Pulumi modules (e.g. when previewing). A build dependency (e.g. on an `exec` Module or Build) is a common way to ensure that the relevant language SDK is installed for the module/action before running Pulumi. We didn't bring this logic along when we adapted the Pulumi plugin commands for 0.13—this is fixed here. Also added a lightweight test project to test this logic (which should also serve us well when making further fixes to this plugin).
vvagaytsev
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In 0.12, we included build dependencies for Pulumi modules (e.g. when previewing). A build dependency (e.g. on an
execModule or Build) is a common way to ensure that the relevant language SDK is installed for the module/action before running Pulumi.We didn't bring this logic along when we adapted the Pulumi plugin commands for 0.13—this is fixed here.
Also added a lightweight test project to test this logic (which should also serve us well when making further fixes to this plugin).
Which issue(s) this PR fixes:
Fixes #6256