be a bit more backwards-compatible: do not deserialise to dict

gardener-attic · Jan 17, 2023 · 19f80d7 · 19f80d7
1 parent 30f47b6
commit 19f80d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/bindings-python/gci/componentmodel.py b/bindings-python/gci/componentmodel.py
@@ -386,8 +386,8 @@ class Resource(Artifact, LabelMethodsMixin):
         OciAccess,
         RelativeOciAccess,
         S3Access,
+        ResourceAccess,
         None,
-        dict,
     ]
     digest: typing.Optional[DigestSpec] = None
     extraIdentity: typing.Dict[str, str] = dataclasses.field(default_factory=dict)

diff --git a/bindings-python/tests/gci/componentmodel_test.py b/bindings-python/tests/gci/componentmodel_test.py
@@ -31,9 +31,9 @@ def test_deserialisation_of_custom_resources():
     component_descriptor = cm.ComponentDescriptor.from_dict(
         component_descriptor_dict=component_descriptor_dict,
     )
-    assert isinstance(component_descriptor.component.resources[0].access, dict)
+    assert isinstance(component_descriptor.component.resources[0].access, cm.ResourceAccess)
     assert component_descriptor.component.resources[1].access is None
-    assert isinstance(component_descriptor.component.resources[2].access, dict)
+    assert isinstance(component_descriptor.component.resources[2].access, cm.ResourceAccess)
     assert isinstance(component_descriptor.component.resources[3].access, cm.RelativeOciAccess)