Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor directory #115

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Remove vendor directory #115

merged 2 commits into from
Apr 19, 2024

Conversation

rishabh-11
Copy link
Collaborator

What this PR does / why we need it:
Remove vendor directory

Which issue(s) this PR fixes:
Fixes #96

Special notes for your reviewer:

Release note:

Removed vendor directory

@rishabh-11 rishabh-11 requested a review from unmarshall April 19, 2024 10:38
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 19, 2024
@gardener-prow gardener-prow bot requested a review from ashwani2k April 19, 2024 10:38
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 19, 2024
@rishabh-11
Copy link
Collaborator Author

/kind enhancement

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 19, 2024
unmarshall
unmarshall reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Apr 19, 2024

LGTM label has been added.

Git tree hash: 0d636680c363470e5bc6a0f2d1b99b2e3a7a09f2

@unmarshall
Copy link
Contributor

/approve

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: unmarshall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 19, 2024
@gardener-prow gardener-prow bot requested a review from unmarshall April 19, 2024 11:12
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Apr 19, 2024

@rishabh-11: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dependency-watchdog-check-vulnerabilities 4fb908d link false /test pull-dependency-watchdog-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@unmarshall
Copy link
Contributor

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Apr 19, 2024

LGTM label has been added.

Git tree hash: e5703b5f3631db5e51e3bf0be845a3d2510376d9

@gardener-prow gardener-prow bot merged commit 2940506 into gardener:master Apr 19, 2024
6 of 7 checks passed
@unmarshall unmarshall deleted the remove-vendor branch April 19, 2024 11:37
@unmarshall
Copy link
Contributor

/cherry-pick rel-1.2.0

@rishabh-11
Copy link
Collaborator Author

/cherry-pick rel-1.2.0

rishabh-11 added a commit to rishabh-11/dependency-watchdog that referenced this pull request Apr 19, 2024
@rishabh-11 @unmarshall
Remove vendor directory (gardener#115)
edbe8dc 
* prepare for vendor folder removal

* added unit test output formatter to test.sh

---------

Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
@rishabh-11 rishabh-11 mentioned this pull request Apr 19, 2024
Merged
rishabh-11 added a commit that referenced this pull request Apr 19, 2024
@rishabh-11 @unmarshall
Remove vendor directory (#115) (#116)
1cf87f1 
* prepare for vendor folder removal

* added unit test output formatter to test.sh

---------

Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwani2k ashwani2k Awaiting requested review from ashwani2k

@unmarshall unmarshall Awaiting requested review from unmarshall

Assignees

@unmarshall unmarshall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove vendor folder
5 participants
@rishabh-11 @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-ci-robot