Export types to make them reusable for other packages #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
merge/squash
size/S
|
@amshuman-kr You have pull request review open invite, please check |
amshuman-kr
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Thanks @rfranzke! Do you plan to reuse them elsewhere?
/lgtm
amshuman-kr
requested changes
Jun 21, 2021
There was a problem hiding this comment.
@rfranzke make check is failing with the following logs. Could you please address them. Apart from that, LGTM.
pkg/restarter/types.go:47:6: exported type Service should have comment or be unexported
pkg/restarter/types.go:51:6: exported type DependantPods should have comment or be unexported
pkg/scaler/types.go:61:6: exported type ProbeDependants should have comment or be unexported
pkg/scaler/types.go:67:6: exported type ProbeConfig should have comment or be unexported
pkg/scaler/types.go:77:6: exported type ProbeDetails should have comment or be unexported
pkg/scaler/types.go:81:6: exported type DependantScaleDetails should have comment or be unexported
Yes, as part of gardener/gardener#2754, the Helm charts will be eliminated in favor of Golang struct usages, and it would be great if the DWD config can be handled similarly.
Could you recommend reasonable doc strings (maybe directly via GitHub suggestions)? I'm not too much into all this code. |
amshuman-kr
requested changes
Jun 21, 2021
Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Export types to make them reusable for other packages
/invite @amshuman-kr
/squash
Release note: