Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For control-plane-as-a-service, no probes will be created #82

Merged
merged 8 commits into from
Apr 28, 2023
Merged

For control-plane-as-a-service, no probes will be created #82

merged 8 commits into from
Apr 28, 2023

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Apr 24, 2023 •
edited by himanshu-kun
Loading

How to categorize this PR?
/kind enhancement
/area control-plane

What this PR does / why we need it:
Avoids creating probes for shoots which do not have any workers.

Which issue(s) this PR fixes:
Fixes #80 and #76

Special notes for your reviewer:

Release note:

Probes will not be created for shoots with no workers.

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2023
@unmarshall unmarshall changed the title added support to contron-plan-as-a-service, no probes are created for… added support for control-plan-as-a-service, no probes are created for… Apr 24, 2023
@unmarshall unmarshall mentioned this pull request Apr 24, 2023
Closed
@unmarshall unmarshall added the kind/enhancement Enhancement, improvement, extension label Apr 25, 2023
@gardener-prow gardener-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 25, 2023
@unmarshall
Copy link
Contributor Author

/area control-plane

@gardener-prow gardener-prow bot added the area/control-plane Control plane related label Apr 25, 2023
@unmarshall
Copy link
Contributor Author

/cc @rishabh-11

@gardener-prow gardener-prow bot requested a review from rishabh-11 April 25, 2023 10:07
@unmarshall
Copy link
Contributor Author

/cc @acumino

@gardener-prow gardener-prow bot requested a review from acumino April 25, 2023 10:07
shafeeqes
shafeeqes reviewed Apr 25, 2023
View reviewed changes
controllers/cluster_controller.go Show resolved Hide resolved
controllers/cluster_controller.go Outdated Show resolved Hide resolved
@shafeeqes
Copy link

typo in PR name, control-plane-as-a-service

@unmarshall unmarshall changed the title added support for control-plan-as-a-service, no probes are created for… added support for control-plane-as-a-service, no probes are created for… Apr 25, 2023
acumino
acumino reviewed Apr 25, 2023
View reviewed changes
hack/addlicenseheaders.sh Outdated Show resolved Hide resolved
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2023
@unmarshall
Copy link
Contributor Author

@acumino, @shafeeqes I have now addressed all your review comments. PTAL.
@rishabh-11, @himanshu-kun please have a look at from DWD perspective and see if you want any change.

shafeeqes
shafeeqes reviewed Apr 26, 2023
View reviewed changes
Copy link

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments.
One minor comment.
Otherwise lgtm

controllers/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
shafeeqes
shafeeqes reviewed Apr 27, 2023
View reviewed changes
Copy link

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
@gardener-prow
Copy link

gardener-prow bot commented Apr 27, 2023

LGTM label has been added.

Git tree hash: 310ee3bade1b7cfe61abc5d035c6579e6cd5dd67

himanshu-kun
himanshu-kun approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort , the structure is much cleaner now!
Just a nit
approving anyways

/lgtm

controllers/endpoint/endpoints_controller.go
type EndpointReconciler struct {
const controllerName = "endpoint"

// Reconciler EndpointReconciler reconciles an Endpoints object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Reconciler EndpointReconciler reconciles an Endpoints object
// Reconciler reconciles an Endpoints object

@gardener-prow
Copy link

gardener-prow bot commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: himanshu-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@gardener-prow gardener-prow bot merged commit e44f10d into gardener:master Apr 28, 2023
@unmarshall unmarshall mentioned this pull request Apr 28, 2023
Closed
@unmarshall unmarshall deleted the cpaas branch April 28, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafeeqes shafeeqes shafeeqes left review comments

@acumino acumino acumino left review comments

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@ashwani2k ashwani2k Awaiting requested review from ashwani2k

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11

Assignees

@himanshu-kun himanshu-kun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not create probe for control-plane-as-a-service shoots
8 participants
@unmarshall @shafeeqes @acumino @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-ci-robot