Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for vSMP MemoryOne and Garden Linux #116

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add support for vSMP MemoryOne and Garden Linux #116

merged 1 commit into from
Aug 23, 2023

Conversation

MrBatschner
Copy link
Contributor

@MrBatschner MrBatschner commented Jul 20, 2023 •
edited
Loading

How to categorize this PR?

/area os
/kind api-change
/kind enhancement
/os garden-linux

What this PR does / why we need it:

Adds support for vSMP MemoryOne on Garden Linux. As first undertakings to support vSMP on top of Garden Linux are done, the Garden Linux extension must offer support for its peculiarities.

The necessary code and APIs for supporting vSMP MemoryOne was taken from the suse-chost extension which already had this support for several years. With this, the Garden Linux extension now understands a providerConfig and also registers for the type OperatingSystemConfig/memoryone-gardenlinux.

Fixes:

Fixes #109

Special notes for your reviewer:

Release note:

The Garden Linux OS extension now features support for vSMP MemoryOne and Garden Linux. It will now consider itself responsible for a new type `OperatingSystemConfig/memoryone-gardenlinux` and understands a `providerConfig` with which certain parameters of MemoryOne can be configured.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/os Operation system related kind/enhancement Enhancement, improvement, extension os/garden-linux Related to Garden Linux OS needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Jul 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 31, 2023
@MrBatschner
add support for vSMP MemoryOne on Garden Linux
08824b2 
The necessary code and APIs for supporing vSMP
MemoryOne was taken from the suse-chost extension
which already had this support for several years.
With this, the Garden Linux extension now
understands a providerConfig and also registers
for the type os/memoryone-gardenlinux.
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 31, 2023
@MrBatschner MrBatschner changed the title Add support for vSMP MemoryOne on Garden Linux Add support for vSMP MemoryOne and Garden Linux Jul 31, 2023
@MrBatschner
Copy link
Contributor Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review August 1, 2023 13:44
@gardener-robot gardener-robot requested review from a team as code owners August 1, 2023 13:44
@danielfoehrKn
Copy link
Contributor

@MrBatschner I'll have a look, sorry for the delay

danielfoehrKn
danielfoehrKn approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@danielfoehrKn danielfoehrKn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out, works great.

@danielfoehrKn danielfoehrKn merged commit 4d92e0a into gardener:master Aug 23, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfoehrKn danielfoehrKn danielfoehrKn approved these changes

Assignees
No one assigned
Labels
area/os Operation system related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else os/garden-linux Related to Garden Linux OS size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boot chost garden-linux with vsmp memory_one
6 participants
@MrBatschner @danielfoehrKn @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot