Implement a Webhook to mutate the OperatingSystemConfig for cgroup drivers #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/os
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
size/xl
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
to keep GNA from deleting the entire drop-in directory as described in gardener/gardener#10809
MrBatschner
force-pushed
the
oscmutator
branch
from
41adfc3 to
e1bab93
Compare
gardener-robot
added
needs/review
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/cla |
|
@MrBatschner I reached out successfully to the cla-assistant to recheck this pull request. |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Roncossek
approved these changes
Nov 21, 2024
gardener-robot
added
the
status/closed
MrBatschner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area os
/kind enhancement
/os garden-linux
What this PR does / why we need it:
Gardener Node Agent was recently enabled to modify the configuration file of containerd adapt its cgroup driver through a dedicated field
.spec.criConfig.cgroupDriverin the OperatingSystemConfig (OSC). With that change, it is no longer necessary to deploy systemd-dropins that run certain scripts to modify containerd and kubelet configuration files during theirExecStartPre. Instead, containerd can be instructed through its OSC to deploy the proper configuration right from the start.This PR implements a mutating webhook that changes the OperatingSystemConfig of a worker pool and sets the cgroup driver of both, containerd and kubelet, to
systemd. It does so by mutating the field.spec.criConfig.cgroupDriverand by extracting and mutating the kubelet config that gets deployed through the OSC.Release note: