Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy code for cloud-config-downloader scenario #138

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Cleanup legacy code for cloud-config-downloader scenario #138

merged 1 commit into from
Apr 11, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Apr 10, 2024 •
edited
Loading

How to categorize this PR?

/area os
/kind cleanup
/os suse-chost

What this PR does / why we need it:
This PR cleans up the legacy code for the cloud-config-downloader scenario before gardener-node-agent was introduced.

Which issue(s) this PR fixes:
Part of gardener/gardener#8023

Special notes for your reviewer:
Follow-up of #112

Release note:

This extension is no longer able to run with Gardener versions lower than `v1.90` when the `UseGardenerNodeAgent` feature gate is disabled.

@rfranzke rfranzke requested review from a team as code owners April 10, 2024 09:18
@gardener-robot gardener-robot added needs/review Needs review area/os Operation system related kind/cleanup Something that is not needed anymore and can be cleaned up os/suse-chost Related to SUSE Container Host OS labels Apr 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 10, 2024
@rfranzke rfranzke mentioned this pull request Apr 10, 2024
Closed
55 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2024
MrBatschner
MrBatschner approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@MrBatschner MrBatschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 11, 2024
@MrBatschner MrBatschner merged commit a04e939 into gardener:master Apr 11, 2024
5 checks passed
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2024
@rfranzke rfranzke deleted the cleanup branch April 12, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBatschner MrBatschner MrBatschner approved these changes

Assignees
No one assigned
Labels
area/os Operation system related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/suse-chost Related to SUSE Container Host OS reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @MrBatschner @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot