Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase create timeout for aws_route.private_utility_zX_nat #38

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Increase create timeout for aws_route.private_utility_zX_nat #38

merged 1 commit into from
Feb 19, 2020

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Feb 18, 2020 •
edited
Loading

What this PR does / why we need it:
Increase create timeout for aws_route.private_utility_zX_nat.

Which issue(s) this PR fixes:
Ref #5

Special notes for your reviewer:

Release note:

The create timeout for `aws_route.private_utility_zX_nat` is now increased to `5m`.

@ialidzhikov
Increase create timeout for aws_route.private_utility_zX_nat
7be6035 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner February 18, 2020 16:01
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 18, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 18, 2020
vpnachev
vpnachev approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rfranzke
rfranzke approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit bb169f3 into gardener:master Feb 19, 2020
@ialidzhikov ialidzhikov deleted the fix/increase-route-create-timeout branch February 19, 2020 09:21
@ialidzhikov ialidzhikov mentioned this pull request Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@vpnachev vpnachev vpnachev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @vpnachev @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2