Pass effective kubelet version to controlplane ensurer
#5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/usability
|
/assign |
timebertt
reviewed
Jan 13, 2022
|
/assign |
|
I cannot say I am very familiar with #3501 (comment) or with the changes from this PR. I left 1 comment from an overall look. |
ialidzhikov
reviewed
Jan 14, 2022
By default, the `.spec.kubernetes.version` is used. However, when the kubelet's unit service description contains the version information then this version is passed.
…l name label and `Cluster` object
This reverts commit 2caddc9.
rfranzke
force-pushed
the
enh/k8s-version-per-pool
branch
from
d48cc2b to
ee62fb3
Compare
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Pass kubelet version in `kubelet.service` unit description * Extend `Ensurer` interface methods with kubelet version * Pass correct `kubeletVersion` to ensurer By default, the `.spec.kubernetes.version` is used. However, when the kubelet's unit service description contains the version information then this version is passed. * Adapt `provider-local` ensurer * Add docs for extensions with CSI migration Ref gardener#3501 (comment) * gardenlets labels OSC with related worker pool name * Generic mutator calculates effective kubelet version based on OSC pool name label and `Cluster` object * Revert "Pass kubelet version in `kubelet.service` unit description" This reverts commit 2caddc9.
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Pass kubelet version in `kubelet.service` unit description * Extend `Ensurer` interface methods with kubelet version * Pass correct `kubeletVersion` to ensurer By default, the `.spec.kubernetes.version` is used. However, when the kubelet's unit service description contains the version information then this version is passed. * Adapt `provider-local` ensurer * Add docs for extensions with CSI migration Ref gardener#3501 (comment) * gardenlets labels OSC with related worker pool name * Generic mutator calculates effective kubelet version based on OSC pool name label and `Cluster` object * Revert "Pass kubelet version in `kubelet.service` unit description" This reverts commit 2caddc9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
/merge squash
What this PR does / why we need it:
After #4971 it is possible to have different Kubernetes versions for worker pools of
Shoots. The provider extensions need to be able to properly deal with this situation. This PR tackles this part bycontrolplanemutator to pass the effective kubelet version to the ensurerWhich issue(s) this PR fixes:
Part of #3501 (comment)
Release note: