Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .ci/resources.yaml when concourse dev-builds are enabled #8740

Merged

Conversation

oliver-goetz
Copy link
Member

How to categorize this PR?

/area delivery
/kind cleanup

What this PR does / why we need it:
After we started building dev-images in concourse again (see here), we don't need to specify additional resources anymore.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @rfranzke

/hold wait until gardener/ci-infra#981 was merged

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from rfranzke October 30, 2023 23:49
@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/delivery Delivery related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2023
@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 31, 2023

LGTM label has been added.

Git tree hash: e5e92ff514f5e9d9aa9103499d943e2cb7d96cb7

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@oliver-goetz
Copy link
Member Author

/hold cancel

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@gardener-prow gardener-prow bot merged commit cf86f81 into gardener:master Oct 31, 2023
1 check passed
@oliver-goetz oliver-goetz deleted the enh/remove-resources-yaml branch February 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants