Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate leader election to leases #711

Merged
merged 1 commit into from
Jul 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion kubernetes/deployment/in-tree/control-cluster-role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ rules:
- nodes/status
- configmaps
- secrets
- endpoints
- events
verbs:
- create
Expand Down
1 change: 0 additions & 1 deletion kubernetes/deployment/in-tree/target-cluster-role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ rules:
- ""
resources:
- nodes
- endpoints
- replicationcontrollers
- pods
verbs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ rules:
- nodes/status
- configmaps
- secrets
- endpoints
- events
verbs:
- create
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ rules:
- ""
resources:
- nodes
- endpoints
- replicationcontrollers
- pods
verbs:
Expand Down
3 changes: 1 addition & 2 deletions pkg/util/client/leaderelectionconfig/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ func DefaultLeaderElectionConfiguration() options.LeaderElectionConfiguration {
LeaseDuration: metav1.Duration{Duration: DefaultLeaseDuration},
RenewDeadline: metav1.Duration{Duration: DefaultRenewDeadline},
RetryPeriod: metav1.Duration{Duration: DefaultRetryPeriod},
// TODO(acumino): migrate default to `leases` in one of the next releases
ResourceLock: rl.EndpointsLeasesResourceLock,
ResourceLock: rl.LeasesResourceLock,
}
}

Expand Down