Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golang version to v1.20.5 #827

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Upgrade golang version to v1.20.5 #827

merged 1 commit into from
Jun 7, 2023

Conversation

rishabh-11
Copy link
Contributor

What this PR does / why we need it:
Upgrade golang version to v1.20.5

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Updated to go v1.20.5

@rishabh-11 rishabh-11 requested a review from a team as a code owner June 7, 2023 11:12
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 7, 2023
elankath
elankath approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@elankath elankath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, I see promauto removed from modules.txt now after removal of vendor file.

@elankath elankath added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 7, 2023
@rishabh-11 rishabh-11 merged commit e356364 into gardener:master Jun 7, 2023
@rishabh-11 rishabh-11 deleted the update-go-v1.20 branch June 7, 2023 11:24
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elankath elankath elankath approved these changes

Assignees

@elankath elankath

Labels
reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rishabh-11 @elankath @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot