Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt extension Deployment's requests && limits and VPA #35

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
The 1st commit adapts the requests to the values according to the usage data. It also drops the cpu limit (see gardener/gardener#5627) and uses 5Gi as memory limit: 4 x 1.25Gi (max memory usage).
The 2nd commit enables VPA by default and sets controlledValues: RequestsOnly (see gardener/gardener#5638).

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The extension Deployment resources and VPA are now adapted as follows:
- cpu limit is removed, memory limit is increased to 5Gi
- cpu and memory requests are reduced to 1m and 50Mi
- VPA is enabled by default in the extension chart values
- VPA's `controlledValues` is changed from `RequestsAndLimits` (default) to `RequestsOnly` 

@ialidzhikov ialidzhikov requested a review from nickytd as a code owner June 30, 2024 10:01
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 30, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 30, 2024
@vlerenc
Copy link
Member

vlerenc commented Jun 30, 2024

Thank you @ialidzhikov.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 30, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 30, 2024
@nickytd nickytd merged commit 695e918 into gardener:main Jun 30, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 30, 2024
@ialidzhikov ialidzhikov deleted the enh/autoscaling-config branch July 1, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants