Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotations in targets ingress resources #45

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

nickytd
Copy link
Collaborator

@nickytd nickytd commented Aug 6, 2024

What this PR does

This PR adds support for adding annotations to target ingresses.

Following example illustrates adding annotations to a grafana target, leveraging the default cert-manager and dns-manager extensions in gardener shoot clusters. Once the ingresses are annorated the respective extensions take over the lifecycle of the dns records and server-side certificates of the expose ingress.

ingress:
  create: true
  ingressClassName: nginx
  annotations:
    cert.gardener.cloud/purpose: managed
    dns.gardener.cloud/class: garden
    dns.gardener.cloud/dnsnames: "*"
    dns.gardener.cloud/ttl: "600"
    nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
  tlsSecretRef:
    name: "grafana-tls"
oidc-apps-controller now supports specifying annotations for the target ingresses

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 6, 2024
@nickytd nickytd merged commit d4960c2 into main Aug 6, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 6, 2024
@nickytd nickytd deleted the with-ingress-annotattions branch August 6, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants