Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubebuilder scaffolding and dependencies, use CRD v1 #59

Merged
merged 11 commits into from
Apr 4, 2022
Merged

Update kubebuilder scaffolding and dependencies, use CRD v1 #59

merged 11 commits into from
Apr 4, 2022

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Nov 8, 2021 •
edited
Loading

What this PR does / why we need it:

Changes:

  • Updated scaffolded files from kubebuilder v3.2.0
  • Switch to CustomResourceDefinition v1 as v1beta1 was Deprecated in k8s v1.16.
  • Controller-runtime dependency was updated to v0.10.2
  • Gardener dependency was updated to v1.36.0

Which issue(s) this PR fixes:
Fixes #25

Special notes for your reviewer:

Release note:

Switch to `CustomResourceDefinition` `v1` for the `Terminal` resource

Go dependencies to `kubernetes/*` and `kubernetes-sigs/controller-runtime` were updated to `v0.22.2` and `v0.10.2` respectively

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 8, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 8, 2021
@petersutter petersutter force-pushed the enh/kubebuilder-update branch from ca2649e to a7ec7b6 Compare November 8, 2021 15:00
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2021
@petersutter petersutter force-pushed the enh/kubebuilder-update branch from a7ec7b6 to dde4770 Compare November 8, 2021 15:18
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2021
@petersutter petersutter marked this pull request as draft November 8, 2021 15:19
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2021
@gardener-robot
Copy link

@grolu, @holgerkoser You have pull request review open invite, please check

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2021
@petersutter
update to latest kubebuilder scaffolding
b5f58d1 
bump dependencies

fix tests by creating valid service account token

bump golang to 1.17.3

fix issue with zap-devel flag
@petersutter petersutter force-pushed the enh/kubebuilder-update branch from 061ee9b to b5f58d1 Compare November 22, 2021 17:46
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
@petersutter petersutter changed the title Use crd v1 Use crd v1 and bump controller-runtime to v0.10.2 Nov 24, 2021
@petersutter petersutter changed the title Use crd v1 and bump controller-runtime to v0.10.2 Update kubebuilder scaffolding and dependencies, use CRD v1 Nov 24, 2021
@petersutter petersutter force-pushed the enh/kubebuilder-update branch from cd54aa4 to b8918ce Compare November 24, 2021 14:19
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 24, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
@petersutter petersutter force-pushed the enh/kubebuilder-update branch from bfe2540 to bf964c0 Compare November 25, 2021 08:33
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2021
@petersutter petersutter marked this pull request as ready for review November 25, 2021 08:41
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 10, 2021
grolu
grolu reviewed Feb 18, 2022
View reviewed changes
config/rbac-rt/auth_proxy_service.yaml
@@ -7,7 +7,7 @@
apiVersion: v1
kind: Service
metadata:
annotations:
annotations: # TODO use ServiceMonitor instead?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this TODO? Should we discuss this?

@petersutter @grolu
Apply suggestions from code review
d0a22c7 
Co-authored-by: Lukas Gross <35373687+grolu@users.noreply.github.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2022
holgerkoser
holgerkoser approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 1, 2022
@petersutter petersutter merged commit 1708f2f into master Apr 4, 2022
@petersutter petersutter deleted the enh/kubebuilder-update branch April 4, 2022 08:56
@petersutter petersutter mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu left review comments

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to CRD v1
7 participants
@petersutter @gardener-robot @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3