-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added K8S 1.8-11.x and the missing -strict #8
Conversation
@hiddeco thanks for paving the way, your PR functioned as documentation on how to contribute for me =D |
build.sh
Outdated
openapi2jsonschema -o "${version}-standalone" --kubernetes --stand-alone "${schema}" | ||
fi | ||
|
||
if [ "${recreate}" = true ] || [ ! -d -o "${version}-local" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra -o
here that is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh woops - I tested what would happen with this this mistake of including -o
and realized that this means that whatever I ran with recreate=false
with a non-existing ...-local
directory were never created.
I'll make sure to fix this, and generate potentially missing ...-local
directories.
# the empirical test I made to determine what adding -o caused
mkdir test
if [ ! -d -o "test" ]; then echo "1"; fi
if [ ! -d "test" ]; then echo "2"; fi
if [ ! -d -o "testNoExistance" ]; then echo "3"; fi
if [ ! -d "testNoExistance" ]; then echo "4"; fi
# output was "4" only
Thanks @willthames for reviewing the changes I made to the generation script. I had generated all the |
@consideRatio - yeah, I noticed because I wanted to generate |
Apologies for taking an age to get back to this, I've not had much time to maintain in a while unfortunately. I've done a bulk update of versions today, and have some plans afoot to move this into a standalone org and get more folks involved as maintainers. I'll ping when I have more details in case you might still be interested. |
@garethr thank you for the work you have done with this and
kubeval
! It made me catch a sneaky bug that took a long time to find. I hope to usekubeval
with an even more satisfactory feeling using these updates.This PR
v1.11.0
v1.10.5
v1.9.9
v1.8.14
-strict
directoriesrecreate=false
inbuild.sh
)