Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to make Nextcloud Picker very handy within Element for Nextcloud to answer this issue.
The idea is to add a button that would open an iframe to select a file and get one of the three link :
It requires to install the app https://github.com/nextcloud/picker on version 1.0.11 or above.
So far, it is a POC.
The way the button is added, using
const interval = setInterval(() => {... }, 100);
isn't satisfying.I don't know how to make
survive the webpack building operation. Indeed, this function isn't directly used by Element for Nextcloud but it needs to exist for the Picker app to be able to call this function (
window.parent.closePickerIframe()
) and close the iframe once the link has been copied. Webpack delete this function at building time as it consider it being unused.