Skip to content

Commit

Permalink
Mitigate getmoto#1793 by restricting maximum version for botocore.
Browse files Browse the repository at this point in the history
botocore v1.11.0 changed it's internal implementation so that it now
uses a different library for HTTP requests. This means that moto's
mocking will not work, and test code will inadvertently call the live
AWS service.

As an interim solution to reduce the impact of this breakage, we
restrict the "required" (ie. recommended) version of botocore so that
users will be less likely to use an incompatible version, and will
receive a pip warning when they do.
  • Loading branch information
garyd203 committed Aug 27, 2018
1 parent a1d095c commit abc15f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"Jinja2>=2.7.3",
"boto>=2.36.0",
"boto3>=1.6.16",
"botocore>=1.9.16",
"botocore>=1.9.16,<1.11",
"cookies",
"cryptography>=2.0.0",
"requests>=2.5",
Expand Down

0 comments on commit abc15f0

Please sign in to comment.