TEST 7702 PR for greptile review bot #4

garyschulte · 2024-07-16T21:42:45Z

Duplicates #7237 here in order to use the greptile review bot

.

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Container verification step in release process automated with the container verify GitHub workflow. New workflow is triggered at the end of the release workflow which will check the release container images starts successfully. Verification test only checks container starts and reach the Ethereum main loop Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Fix some reasons for chain download halts when syncing Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Check and test for the unused container rule, and only returncontract targets can have truncated data rule. Also test the other subcontainer rules in unit tests. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…#7247) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…transaction validation and tx pool logic Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…to be necessary before final fork choice update Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…ting accounts as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…only available in the prague hard fork Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…yet exist Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…rty (hyperledger#7222) * Add build version option to prefix git hash with custom version property * Refactor to make appending the git hash a boolean property. Include a commented-out example of how to use the properties in the gradle file Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…yperledger#7221) Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Ties <71668189+TiesD@users.noreply.github.com> Co-authored-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* Add option for LUKSO network Signed-off-by: Wolmin <lamonos123@gmail.com> * Add tests for LUKSO Signed-off-by: Wolmin <lamonos123@gmail.com> * Apply spotless Signed-off-by: Wolmin <lamonos123@gmail.com> * Add changelog entry Signed-off-by: Wolmin <lamonos123@gmail.com> * Fix duplicate func Signed-off-by: Wolmin <lamonos123@gmail.com> * Fix changelog Signed-off-by: Wolmin <lamonos123@gmail.com> * Add bootnodes to genesis Signed-off-by: Wolmin <lamonos123@gmail.com> --------- Signed-off-by: Wolmin <lamonos123@gmail.com> Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…erledger#7245) Make the max code size and max initcode size a part of the EVM configuration. As part of the change we need to move the tasks CodeFactory once handled as a static class and move it into the EVM. This has a nice follow on effect that we don't need to pass in max EOF versions or max code sizes anymore. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* fix the synchronizer usage Signed-off-by: Leni <leniram159@gmail.com> * fix Identifier usage Signed-off-by: Leni <leniram159@gmail.com> --------- Signed-off-by: Leni <leniram159@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Add Genesis ("CancunEOFTime") and reference test ("CancunEOF") support for a temporary Cancun+EOF fork, in anticipation of potential devnets. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…er to understand Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Increment private nonce even if transaction failed Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Co-authored-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* feat: --profile can load external profiles * fix external profile name method * fix ProfilesCompletionCandidate * test: Add unit tests * changelog: Update changelog * test: Fix TomlConfigurationDefaultProviderTest * test: Fix BesuCommandTest --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Documentation has been moved to GitHub pages and no longer use readthedocs. Updated the README status badge for docs with correct link Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* typos Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…t instances of the world updater, renamed some classes Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* Add evmtool block-test subcommand Add an evmtool subcommand that will run non-hive blockchain tests. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* make snap tasks switching Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…edger#7309) * 6612: Remove deprecated sync modes and related helper methods Signed-off-by: Matilda-Clerke <matilda.shay.clerke@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Fix a number of issues found in reference tests and evmone tests. - Be tolerant of more nulls in json - Support ContainerKind in reference tests - re-order EXTCALL oeprands - correct return value for REVERT in EXT*CALL - re-order EOFCREATE code validation Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* use gnark-crypto for bls precompiles Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Check for OOG earlier in DataCopy. Add unit tests to cover operation branches. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* disable flaky test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * disable flaky test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* Update parameterized unit tests so the enumerate with --dry-run * Update the prague-withdrawal.json unit test to handle current code Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

… code Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…ance nor code" This reverts commit 9c9121a. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* removed PKI backed QBFT Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* add request type for consolidations, encoder, decoder and tests * added raw tx for consolidation * add consolidation reqs to EngineGetPayloadResultV4 * set storage slot value to 0 initially and value for tx * updates plugin api Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

… the transaction object (hyperledger#7323) * fix: Use Builder for JsonCallParameter * changelog * add additional unit tests * fix: Update builder to withGas to match the json eth_call --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

… isn't set Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

… nonces Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

greptile-apps

PR Summary

Added PragueAcceptanceTestService.java for testing Prague engine JSON-RPC calls.
Introduced SetCodeTransactionAcceptanceTest.java for SetCode transaction type.
Updated Transaction.java and TransactionType.java to support EIP-7702 transactions.
Added SetCodeTransactionEncoder and SetCodeTransactionDecoder for encoding/decoding.
Modified MainnetTransactionProcessor.java and MainnetTransactionValidator.java to handle new transaction types and authorization lists.

_{29 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-07-16T21:46:04Z

...va/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/EnginePayloadStatusResult.java

-      final Optional<String> validationError) {
+      @JsonProperty("status") final EngineStatus status,
+      @JsonProperty("latestValidHash") final Hash latestValidHash,
+      @JsonProperty("errorMessage") final Optional<String> validationError) {


Style: Consider renaming the field validationError to errorMessage for consistency.

too opinionated. validationError is more descriptive in this context

greptile-apps · 2024-07-16T21:46:49Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/SetCodeAuthorization.java

+
+  @Override
+  public Optional<Long> nonce() {
+    return nonces.size() == 1 ? Optional.of(nonces.getFirst()) : Optional.empty();


Spelling: List.getFirst() is not a valid method. Use List.get(0) instead.

this is a java 21 method

greptile-apps · 2024-07-16T21:47:49Z

...ore/src/main/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionDecoder.java

+    if (!input.nextIsList()) {
+      throw new IllegalArgumentException("Optional nonce must be an list, but isn't");


Spelling: Potential typo: 'an list' should be 'a list'.

greptile-apps · 2024-07-16T21:51:34Z

ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/BlockDataGenerator.java

+        // TODO 7702
+      case SET_CODE -> null;


Logic: The SET_CODE transaction type is currently returning null. Ensure this is implemented before merging.

daniellehrner and others added 30 commits July 16, 2024 14:01

EIP 7702 first draft

619f4a1

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added CHANGELOG.md entry

6420df0

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

bug fixes, added first tests

73bd969

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Remove deprecation message for --Xp2p-peer-lower-bound (hyperledger…

030721d

…#7247) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

less invasive code injection approach

f4e6b76

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added missing java doc & fixed test

2db71af

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added (currently non-working) acceptance test, some bug fixes in the …

f133219

…transaction validation and tx pool logic Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

fix spotless

64f5f73

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

updated acceptance test, still not working, newPayload request seems …

f2c6b48

…to be necessary before final fork choice update Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

use correct world state to inject temporary code, inject code in exis…

59827f9

…ting accounts as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

renamed test service to prague, because the engine versions used are …

123ce12

…only available in the prague hard fork Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

fixed acceptance test, some bug fixes if authorized account does not …

1dad4d1

…yet exist Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Handle invalid snap getTrieNode requests with empty paths gracefully (h…

4c4452f

…yperledger#7221) Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Update Docker base image to Ubuntu 24.04 (hyperledger#7251)

96bbfd5

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Fix flaky SECP256R1 test (hyperledger#7249)

f62c0cc

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

update to work with the new max retries value (hyperledger#7253)

3b73512

Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

fixed bug introduced through merge of main, made acceptance test easi…

89714ad

…er to understand Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added missing java docs

71105a7

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

removed unnecessary tag

5eac657

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

make encodeSingleSetCode public again

6a56ff8

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Snapserver responses to return at least one response (hyperledger#7190)

7fcc42f

Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

gtebrean and others added 29 commits July 16, 2024 14:01

[MINOR] Fixed some typos (hyperledger#7299)

48477bc

* typos Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

refactored to share one AuthorizedAccountService between the differen…

429a5b9

…t instances of the world updater, renamed some classes Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

spotless

1852b3f

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

load code for authorization at the beginning of the transaction

373ecab

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

ignore authorization if chain id doesn't match

9b2b07e

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

cache authority address, evmtool: do not fail if sender address is wrong

5d035af

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Add evmtool block-test subcommand (hyperledger#7293)

1207ff1

* Add evmtool block-test subcommand Add an evmtool subcommand that will run non-hive blockchain tests. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Make the retrying snap tasks switching (hyperledger#7307)

50dd40f

* make snap tasks switching Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

6612: Remove deprecated sync modes and related helper methods (hyperl…

641d13f

…edger#7309) * 6612: Remove deprecated sync modes and related helper methods Signed-off-by: Matilda-Clerke <matilda.shay.clerke@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

test template refactor, bump besu-native to 0.9.2 (hyperledger#7315)

d22c9c6

Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Feature/use gnark-crypto for eip-2537 (hyperledger#7316)

cf878ed

* use gnark-crypto for bls precompiles Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Update datacopy (hyperledger#7319)

5035d9a

Check for OOG earlier in DataCopy. Add unit tests to cover operation branches. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

persist accounts that have storage updates, but no nonce, balance nor…

62ced3d

… code Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Revert "persist accounts that have storage updates, but no nonce, bal…

6e5b1d7

…ance nor code" This reverts commit 9c9121a. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Stop transaction selection on TX_EVALUATION_TOO_LONG (hyperledger#7330)

283ab8b

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

message frame buider will create AuthorizedCodeService by itsef if it…

4eeb5f0

… isn't set Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Merge branch 'main' into feat/issue-7205/eip-7702v1

c63d4fa

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

get correct nonce for authorization

eea2281

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

nonce only returns a vaid nonce, new method nonceList returns all the…

22e6ff6

… nonces Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

greptile-apps bot reviewed Jul 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEST 7702 PR for greptile review bot #4

TEST 7702 PR for greptile review bot #4

garyschulte commented Jul 16, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Jul 16, 2024

garyschulte Jul 16, 2024

greptile-apps bot Jul 16, 2024

garyschulte Jul 16, 2024

greptile-apps bot Jul 16, 2024

greptile-apps bot Jul 16, 2024

		if (!input.nextIsList()) {
		throw new IllegalArgumentException("Optional nonce must be an list, but isn't");

TEST 7702 PR for greptile review bot #4

Are you sure you want to change the base?

TEST 7702 PR for greptile review bot #4

Conversation

garyschulte commented Jul 16, 2024 • edited Loading

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jul 16, 2024

Choose a reason for hiding this comment

garyschulte Jul 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Jul 16, 2024

Choose a reason for hiding this comment

garyschulte Jul 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Jul 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Jul 16, 2024

Choose a reason for hiding this comment

garyschulte commented Jul 16, 2024 •

edited

Loading