Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate metrics options #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Isolate metrics options #5

wants to merge 3 commits into from

Conversation

garyschulte
Copy link
Owner

Testing greptile review bot

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Isolated metrics options from BesuCommand into a new MetricsOptionGroup class, improving code organization and modularity.

  • Created new MetricsOptionGroup class in besu/src/main/java/org/hyperledger/besu/cli/options/stable/MetricsOptionGroup.java
  • Moved metrics-related command-line options from BesuCommand to MetricsOptionGroup
  • Updated BesuCommand to use the new MetricsOptionGroup for handling metrics options
  • Implemented getter methods in MetricsOptionGroup for accessing metrics configuration
  • Set default values for most metrics options in MetricsOptionGroup for easier out-of-the-box usage

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants